code to use HPE SMARTREDIS #213
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jedwards4b - I have asked that output is written to the mediator or driver log file rather than the PET log file to document smartsim usage. Can you also summarize the two new xml variables in the description of the PR. |
mvertens
approved these changes
Sep 21, 2021
| end if | ||
| call mpi_bcast (use_smartredis, 1, MPI_LOGICAL, 0, COMP_COMM, ier) | ||
| call mpi_bcast (create_smartsim_cluster, 1, MPI_LOGICAL, 0, COMP_COMM, ier) | ||
| if (use_smartredis) then |
There was a problem hiding this comment.
Can you please write to the cmeps logunit and not the PET. It would be good to have this in the mediator log file. Or does this belong in the driver write file?
|
at this point in initialization those logs are not yet available
…On Tue, Sep 21, 2021 at 9:36 AM mvertens ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In drivers/cime/esmApp.F90
<#213 (comment)>:
> + !-----------------------------------------------------------------------------
+ ! Initialize the CrayLabs SmartRedis client, a stub is provided in share if
+ ! smartsim is not used. This client shall be used by all component models.
+ !-----------------------------------------------------------------------------
+
+ if (iam==0) then
+ open(newunit=fileunit, status="old", file="drv_in")
+ read(fileunit, smartsim_inparm, iostat=ier)
+ if (ier > 0) then
+ call shr_sys_abort('esmApp: error reading in smartsim_inparm namelist from drv_in')
+ end if
+ close(fileunit)
+ end if
+ call mpi_bcast (use_smartredis, 1, MPI_LOGICAL, 0, COMP_COMM, ier)
+ call mpi_bcast (create_smartsim_cluster, 1, MPI_LOGICAL, 0, COMP_COMM, ier)
+ if (use_smartredis) then
Can you please write to the cmeps logunit and not the PET. It would be
good to have this in the mediator log file. Or does this belong in the
driver write file?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#213 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOXUGHGACZVAV4MBQ2T7T3UDCQ7HANCNFSM5AP5GGEQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Jim Edwards
CESM Software Engineer
National Center for Atmospheric Research
Boulder, CO
|
|
@jedwards4b - what is the status of this PR? |
|
I have a meeting next week with the smartsim developers, they tell me that they have a new method |
mvertens
pushed a commit
to mvertens/CMEPS
that referenced
this pull request
Jan 30, 2023
1 task
jedwards4b
added a commit
that referenced
this pull request
Feb 1, 2023
changes needed for CDEPS PR #213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds an interface to the HPE SmartSim database. Currently only tested on casper with gnu compiler.
Adds a test mod for testing with smartsim.
Requires CESM_share ESCOMP/CESM_share#5
Provides new xml boolean variables USE_SMARTSIM and CREATE_SMARTSIM_CLUSTER to indicate that this mode should be invoked.
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers?
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):
Testing performed if application target is UFS-coupled:
Testing performed if application target is UFS-HAFS:
Hashes used for testing: